lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Dec 2019 15:56:19 +0100 From: Guillaume Nault <gnault@...hat.com> To: Aditya Pakki <pakki001@....edu> Cc: klju@....edu, Michal Ostrowski <mostrows@...thlink.net>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] pppoe: remove redundant BUG_ON() check in pppoe_pernet On Thu, Dec 05, 2019 at 05:03:42PM -0600, Aditya Pakki wrote: > Passing NULL to pppoe_pernet causes a crash via BUG_ON. > Dereferencing net in net_generici() also has the same effect. This patch > removes the redundant BUG_ON check on the same parameter. > > Signed-off-by: Aditya Pakki <pakki001@....edu> > --- > drivers/net/ppp/pppoe.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c > index a44dd3c8af63..d760a36db28c 100644 > --- a/drivers/net/ppp/pppoe.c > +++ b/drivers/net/ppp/pppoe.c > @@ -119,8 +119,6 @@ static inline bool stage_session(__be16 sid) > > static inline struct pppoe_net *pppoe_pernet(struct net *net) > { > - BUG_ON(!net); > - > return net_generic(net, pppoe_net_id); > } > Looks like a net-next patch, but net-next is currently closed (take a look Documentation/networking/netdev-FAQ.rst for details). You can add my ack when you repost: Acked-by: Guillaume Nault <gnault@...hat.com>
Powered by blists - more mailing lists