netdev - Re: [PATCH v4.14] tcp: exit if nothing to retransmit on RTO timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 7 Dec 2019 12:55:01 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Neal Cardwell <ncardwell@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Subject: Re: [PATCH v4.14] tcp: exit if nothing to retransmit on RTO timeout

On Fri, Dec 06, 2019 at 10:20:16AM -0800, Eric Dumazet wrote:
> Two upstream commits squashed together for v4.14 stable :
> 
>  commit 88f8598d0a302a08380eadefd09b9f5cb1c4c428 upstream.
> 
>   Previously TCP only warns if its RTO timer fires and the
>   retransmission queue is empty, but it'll cause null pointer
>   reference later on. It's better to avoid such catastrophic failure
>   and simply exit with a warning.
> 
> Squashed with "tcp: refactor tcp_retransmit_timer()" :
> 
>  commit 0d580fbd2db084a5c96ee9c00492236a279d5e0f upstream.

Note, this commit is only in Dave's tree, not stable just yet.  I'll
queue this up now, but I'm expecting that commit will come in to the
stable trees through the "normal" stable networking process.

thanks,

greg k-h