netdev - Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 7 Dec 2019 18:13:34 +0100
From:   Simon Horman <simon.horman@...ronome.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-arm-kernel@...ts.infradead.org, grygorii.strashko@...com,
        robh+dt@...nel.org, rafal@...ecki.pl, davem@...emloft.net,
        andrew@...n.ch, mark.rutland@....com, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Eric Anholt <eric@...olt.net>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells

On Fri, Dec 06, 2019 at 10:19:09AM -0800, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
>  #size-cells properties, correct those.
> 
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <simon.horman@...ronome.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Thanks Florian,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@...ronome.com>

> ---
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
>  		mdio: mdio@...02000 {
>  			compatible = "brcm,iproc-mdio";
>  			reg = <0x18002000 0x8>;
> -			#size-cells = <1>;
> -			#address-cells = <0>;
> +			#size-cells = <0>;
> +			#address-cells = <1>;
>  			status = "disabled";
>  
>  			gphy0: ethernet-phy@0 {
> -- 
> 2.17.1
>