netdev - Re: [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191207185232.eau34ble7eigv2vq@salvia>
Date:   Sat, 7 Dec 2019 19:52:32 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Marco Oliverio <marco.oliverio@...aza.com>
Cc:     netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
        fw@...len.de, rocco.folino@...aza.com
Subject: Re: [PATCH nf] netfilter: nf_queue: enqueue skbs with NULL dst

On Mon, Dec 02, 2019 at 07:54:30PM +0100, Marco Oliverio wrote:
> Bridge packets that are forwarded have skb->dst == NULL and get
> dropped by the check introduced by
> b60a77386b1d4868f72f6353d35dabe5fbe981f2 (net: make skb_dst_force
> return true when dst is refcounted).
> 
> To fix this we check skb_dst() before skb_dst_force(), so we don't
> drop skb packet with dst == NULL. This holds also for skb at the
> PRE_ROUTING hook so we remove the second check.

Applied, thanks.