netdev - Re: [PATCH net] net_sched: validate TCA_KIND attribute in tc_chain_tmplt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be2b2219-75a7-0724-51b4-2a057936cd37@gmail.com>
Date:   Sat, 7 Dec 2019 11:32:16 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Cong Wang <xiyou.wangcong@...il.com>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        syzbot <syzkaller@...glegroups.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net] net_sched: validate TCA_KIND attribute in
 tc_chain_tmplt_add()



On 12/7/19 10:57 AM, Cong Wang wrote:
> On Sat, Dec 7, 2019 at 10:49 AM Eric Dumazet <edumazet@...gle.com> wrote:
>>
>> Use the new tcf_proto_check_kind() helper to make sure user
>> provided value is well formed.
> ...
>> Fixes: 6f96c3c6904c ("net_sched: fix backward compatibility for TCA_KIND")
>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>> Reported-by: syzbot <syzkaller@...glegroups.com>
>> Cc: Cong Wang <xiyou.wangcong@...il.com>
>> Cc: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
>> Cc: Jamal Hadi Salim <jhs@...atatu.com>
>> Cc: Jiri Pirko <jiri@...nulli.us>
> 
> Acked-by: Cong Wang <xiyou.wangcong@...il.com>
> 
> Just a nit: the extack message should be for a chain template, not
> for a TC filter.

Thanks, I will send a V2 with an updated message.