netdev - Re: [Patch net] gre: refetch erspan header from skb->data after pskb_may

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 07 Dec 2019 11:54:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xiyou.wangcong@...il.com
Cc:     netdev@...r.kernel.org, lorenzo.bianconi@...hat.com
Subject: Re: [Patch net] gre: refetch erspan header from skb->data after
 pskb_may_pull()

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Thu,  5 Dec 2019 19:39:02 -0800

> After pskb_may_pull() we should always refetch the header
> pointers from the skb->data in case it got reallocated.
> 
> In gre_parse_header(), the erspan header is still fetched
> from the 'options' pointer which is fetched before
> pskb_may_pull().
> 
> Found this during code review of a KMSAN bug report.
> 
> Fixes: cb73ee40b1b3 ("net: ip_gre: use erspan key field for tunnel lookup")
> Cc: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable, thanks.