lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20191207.115754.627115468855491396.davem@davemloft.net> Date: Sat, 07 Dec 2019 11:57:54 -0800 (PST) From: David Miller <davem@...emloft.net> To: grygorii.strashko@...com Cc: netdev@...r.kernel.org, andrew@...n.ch, f.fainelli@...il.com, nsekhar@...com, linux-kernel@...r.kernel.org, hkallweit1@...il.com Subject: Re: [PATCH v2] net: phy: dp83867: fix hfs boot in rgmii mode From: Grygorii Strashko <grygorii.strashko@...com> Date: Fri, 6 Dec 2019 14:34:32 +0200 > The commit ef87f7da6b28 ("net: phy: dp83867: move dt parsing to probe") > causes regression on TI dra71x-evm and dra72x-evm, where DP83867 PHY is > used in "rgmii-id" mode - the networking stops working. > Unfortunately, it's not enough to just move DT parsing code to .probe() as > it depends on phydev->interface value, which is set to correct value abter > the .probe() is completed and before calling .config_init(). So, RGMII > configuration can't be loaded from DT. > > To fix and issue > - move RGMII validation code to .config_init() > - parse RGMII parameters in dp83867_of_init(), but consider them as > optional. > > Fixes: ef87f7da6b28 ("net: phy: dp83867: move dt parsing to probe") > Signed-off-by: Grygorii Strashko <grygorii.strashko@...com> > --- > v2: > - fixed comments in code Applied.
Powered by blists - more mailing lists