netdev - Re: [PATCH net v2] net_sched: validate TCA_KIND attribute in tc_chain_tmplt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191207.120628.389185869668594760.davem@davemloft.net>
Date:   Sat, 07 Dec 2019 12:06:28 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com, xiyou.wangcong@...il.com,
        marcelo.leitner@...il.com, jhs@...atatu.com, jiri@...nulli.us
Subject: Re: [PATCH net v2] net_sched: validate TCA_KIND attribute in
 tc_chain_tmplt_add()

From: Eric Dumazet <edumazet@...gle.com>
Date: Sat,  7 Dec 2019 11:34:45 -0800

> Use the new tcf_proto_check_kind() helper to make sure user
> provided value is well formed.
 ...
> Fixes: 6f96c3c6904c ("net_sched: fix backward compatibility for TCA_KIND")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Applied and queued up for -stable.

Oh how I love such long chains of stable backport requirements... ("gdc" is
"git describe --contains")

[davem@...alhost net]$ gdc 6f96c3c6904c
v5.4-rc4~6^2~79
[davem@...alhost net]$ git show 6f96c3c6904c | grep Fixes
    Fixes: 62794fc4fbf5 ("net_sched: add max len check for TCA_KIND")
[davem@...alhost net]$ gdc 62794fc4fbf5
v5.4-rc1~14^2~68
[davem@...alhost net]$ git show 62794fc4fbf5 | grep Fixes
    Fixes: 8b4c3cdd9dd8 ("net: sched: Add policy validation for tc attributes")
[davem@...alhost net]$ gdc 8b4c3cdd9dd8
v4.19-rc7~7^2~2
[davem@...alhost net]$ git show 8b4c3cdd9dd8 | grep Fixes
    The 2 Fixes tags below cover the latest additions. The other attributes
    Fixes: 5bc1701881e39 ("net: sched: introduce multichain support for filters")
    Fixes: d47a6b0e7c492 ("net: sched: introduce ingress/egress block index attributes for qdisc")
[davem@...alhost net]$ gdc 5bc1701881e39
v4.13-rc1~157^2~434^2~2
[davem@...alhost net]$ gdc d47a6b0e7c492
v4.16-rc1~123^2~139^2~5

I mean seriously, that is such a lovely chain of fixups for fixups... :-)