netdev - Re: [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe stage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01039df6-8e38-cd04-6da1-35c1014bee0f@pengutronix.de>
Date:   Sun, 8 Dec 2019 11:56:26 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Sean Nyekjaer <sean@...nix.com>,
        Joakim Zhang <qiangqing.zhang@....com>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>
Cc:     dl-linux-imx <linux-imx@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH V2 2/4] can: flexcan: try to exit stop mode during probe
 stage

On 12/8/19 11:47 AM, Sean Nyekjaer wrote:
>> But both patches:
>>
>>      can: flexcan: fix deadlock when using self wakeup
>>      can: flexcan: try to exit stop mode during probe stage
>>
>> are not yet mainline, so if "can: flexcan: fix deadlock when using self
>> wakeup" fixes the problem and goes into stable we don't need "can:
>> flexcan: try to exit stop mode during probe stage", right?
>>
>>> That's what i meant by this patch doesn't do any harm to have the check
>>> included.
>>
>> I don't want to have code in the driver that serves no purpose.
> 
> Fine with me, I'm continuing to have the patch included in my tree until 
> all devices are upgraded with:
> 	can: flexcan: fix deadlock when using self wakeup

That makes sende in your usecase, as you already have "can: flexcan: try
to exit stop mode during probe stage" in your tree.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)