| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20191207.160442.1447373592334938477.davem@davemloft.net> Date: Sat, 07 Dec 2019 16:04:42 -0800 (PST) From: David Miller <davem@...emloft.net> To: bpf@...r.kernel.org, netdev@...r.kernel.org CC: ast@...nel.org, daniel@...earbox.net, tglx@...utronix.de Subject: [RFC v1 PATCH 5/7] bpf: Use bpf prog locking in trampoline code. Instead of preemption disable/enable. Signed-off-by: David S. Miller <davem@...emloft.net> --- kernel/bpf/trampoline.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/bpf/trampoline.c b/kernel/bpf/trampoline.c index 7e89f1f49d77..52e39892fec4 100644 --- a/kernel/bpf/trampoline.c +++ b/kernel/bpf/trampoline.c @@ -195,8 +195,8 @@ void bpf_trampoline_put(struct bpf_trampoline *tr) mutex_unlock(&trampoline_mutex); } -/* The logic is similar to BPF_PROG_RUN, but with explicit rcu and preempt that - * are needed for trampoline. The macro is split into +/* The logic is similar to BPF_PROG_RUN, but with explicit rcu and bpf + * prog lock that are needed for trampoline. The macro is split into * call _bpf_prog_enter * call prog->bpf_func * call __bpf_prog_exit @@ -206,7 +206,7 @@ u64 notrace __bpf_prog_enter(void) u64 start = 0; rcu_read_lock(); - preempt_disable(); + bpf_prog_lock(); if (static_branch_unlikely(&bpf_stats_enabled_key)) start = sched_clock(); return start; @@ -229,7 +229,7 @@ void notrace __bpf_prog_exit(struct bpf_prog *prog, u64 start) stats->nsecs += sched_clock() - start; u64_stats_update_end(&stats->syncp); } - preempt_enable(); + bpf_prog_unlock(); rcu_read_unlock(); } -- 2.20.1
Powered by blists - more mailing lists