netdev - Re: [PATCH net] net: flow_dissector: fix tcp flags dissection on big-endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191209160626.npmosk2ehmiuthya@salvia>
Date:   Mon, 9 Dec 2019 17:06:26 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     netdev@...r.kernel.org
Cc:     netfilter-devel@...r.kernel.org, davem@...emloft.net,
        geert@...ux-m68k.org, jiri@...lanox.com
Subject: Re: [PATCH net] net: flow_dissector: fix tcp flags dissection on
 big-endian

On Mon, Dec 09, 2019 at 05:04:30PM +0100, Pablo Neira Ayuso wrote:
> Hi,
> 
> Please, withdraw this patch.
>
> I can fix this by using TCPHDR_* definitions.

Oh actually, that's only true for my nf_flow_table_offload code.

But not for the flow dissector code, which is using tcp_flag_word().

I will revamp and send v2.