lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20191208.224112.2234468529480733416.davem@davemloft.net> Date: Sun, 08 Dec 2019 22:41:12 -0800 (PST) From: David Miller <davem@...emloft.net> To: ms@....tdt.de Cc: andrew.hendry@...il.com, edumazet@...gle.com, linux-x25@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net/x25: add new state X25_STATE_5 From: Martin Schiller <ms@....tdt.de> Date: Mon, 09 Dec 2019 06:28:53 +0100 > On 2019-12-07 20:59, David Miller wrote: >> From: Martin Schiller <ms@....tdt.de> >> Date: Fri, 6 Dec 2019 14:34:18 +0100 >> >>> + switch (frametype) { >>> + >>> + case X25_CLEAR_REQUEST: >> Please remove this unnecessary empty line. >> >>> + if (!pskb_may_pull(skb, X25_STD_MIN_LEN + 2)) >>> + goto out_clear; >> A goto path for a single call site? Just inline the operations here. > > Well, I was guided by the code style of the other states. > I could add a patch to also clean up the other states. > What do you think? Leave the other states and existing code alone. Make your new code reasonable.
Powered by blists - more mailing lists