netdev - Re: [PATCH] net/ipv4/tcp.c: cleanup duplicate initialization of sk->sk_state in tcp_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191209.095305.52672763318299767.davem@davemloft.net>
Date:   Mon, 09 Dec 2019 09:53:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     kuni1840@...il.com
Cc:     edumazet@...gle.com, kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, kuniyu@...zon.co.jp
Subject: Re: [PATCH] net/ipv4/tcp.c: cleanup duplicate initialization of
 sk->sk_state in tcp_init_sock()

From: kuni1840@...il.com
Date: Sun,  8 Dec 2019 14:31:27 +0000

> From: Kuniyuki Iwashima <kuni1840@...il.com>
> 
> When a TCP socket is created, sk->sk_state is initialized twice as
> TCP_CLOSE in sock_init_data() and tcp_init_sock(). The tcp_init_sock() is
> always called after the sock_init_data(), so it is not necessary to update
> sk->sk_state in the tcp_init_sock().
> 
> Before v2.1.8, the code of the two functions was in the inet_create(). In
> the patch of v2.1.8, the tcp_v4/v6_init_sock() were added and the code of
> initialization of sk->state was duplicated.
> 
> Signed-off-by: Kuniyuki Iwashima <kuni1840@...il.com>

Please format your Subject line correctly, it should be of the form:

	Subject: [PATCH $PATCH_VERSION $TARGET_GIT_TREE] subsystem_prefix: Description.

Using a source file path in the Subject line is not appropriate.

So when you respin this patch you could say:

	Subject: [PATCH v2 net-next] tcp: Cleanup duplicate initialization of sk->sk_state.