netdev - Re: [PATCHv2 net] sctp: get netns from asoc and ep base

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191209.101403.781347318798443818.davem@davemloft.net>
Date:   Mon, 09 Dec 2019 10:14:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, linux-sctp@...r.kernel.org,
        marcelo.leitner@...il.com, nhorman@...driver.com
Subject: Re: [PATCHv2 net] sctp: get netns from asoc and ep base

From: Xin Long <lucien.xin@...il.com>
Date: Mon,  9 Dec 2019 13:45:18 +0800

> Commit 312434617cb1 ("sctp: cache netns in sctp_ep_common") set netns
> in asoc and ep base since they're created, and it will never change.
> It's a better way to get netns from asoc and ep base, comparing to
> calling sock_net().
> 
> This patch is to replace them.
> 
> v1->v2:
>   - no change.
> 
> Suggested-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
> Signed-off-by: Xin Long <lucien.xin@...il.com>
> Acked-by: Neil Horman <nhorman@...driver.com>

This looks like a cleanup rather than a bug fix, so net-next right?

Otherwise we need a Fixes: tag here and a better explanation in the
commit message about what problem this fixes.  Are the netns's wrong
sometimes without this conversion for example?

Thanks.