netdev - Re: [PATCH net] selftests: forwarding: Delete IPv6 address at the end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191209.102050.2106424689422479418.davem@davemloft.net>
Date:   Mon, 09 Dec 2019 10:20:50 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     idosch@...sch.org
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [PATCH net] selftests: forwarding: Delete IPv6 address at the
 end

From: Ido Schimmel <idosch@...sch.org>
Date: Mon,  9 Dec 2019 08:56:34 +0200

> From: Ido Schimmel <idosch@...lanox.com>
> 
> When creating the second host in h2_create(), two addresses are assigned
> to the interface, but only one is deleted. When running the test twice
> in a row the following error is observed:
> 
> $ ./router_bridge_vlan.sh
> TEST: ping                                                          [ OK ]
> TEST: ping6                                                         [ OK ]
> TEST: vlan                                                          [ OK ]
> $ ./router_bridge_vlan.sh
> RTNETLINK answers: File exists
> TEST: ping                                                          [ OK ]
> TEST: ping6                                                         [ OK ]
> TEST: vlan                                                          [ OK ]
> 
> Fix this by deleting the address during cleanup.
> 
> Fixes: 5b1e7f9ebd56 ("selftests: forwarding: Test routed bridge interface")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>

Applied, but wasn't the idea that we run these things in a separate
network namespace so that we don't pollute the top level config even
if the script dies mid-way or something?