netdev - Re: [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper SFP modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191209223813.GS25745@shell.armlinux.org.uk>
Date:   Mon, 9 Dec 2019 22:38:13 +0000
From:   Russell King - ARM Linux admin <linux@...linux.org.uk>
To:     David Miller <davem@...emloft.net>
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/4] Add support for slow-to-probe-PHY copper
 SFP modules

On Mon, Dec 09, 2019 at 02:35:25PM -0800, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Mon, 09 Dec 2019 14:34:49 -0800 (PST)
> 
> > From: Russell King - ARM Linux admin <linux@...linux.org.uk>
> > Date: Mon, 9 Dec 2019 14:15:25 +0000
> > 
> >> This series, following on from the previous adding SFP+ copper support,
> >> adds support for a range of Copper SFP modules, made by a variety of
> >> companies, all of which have a Marvell 88E1111 PHY on them, but take
> >> far longer than the Marvell spec'd 15ms to start communicating on the
> >> I2C bus.
> >> 
> >> Researching the Champion One 1000SFPT module reveals that TX_DISABLE is
> >> routed through a MAX1971 switching regulator and reset IC which adds a
> >> 175ms delay to releasing the 88E1111 reset.
> >> 
> >> It is not known whether other modules use a similar setup, but there
> >> are a range of modules that are slow for the Marvell PHY to appear.
> >> 
> >> This patch series adds support for these modules by repeatedly trying
> >> to probe the PHY for up to 600ms.
> > 
> > Patch #3 gets full rejects when I try to apply this series.
> > 
> > Please respin, adding Andrew's ACKs.
> 
> Oh nevermind, I see this depends upon a series that's now in v2 and
> thus appears later int he queue.

Yep.  I'm hoping some comments will be forthcoming on that series soon.

Thanks for looking anyway.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up