netdev - Re: [PATCH net-next 1/5] rtnetlink: provide permanent hardware address in RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c64e986c976b6b647b86c1243d356a8b78483c36.camel@sipsolutions.net>
Date:   Tue, 10 Dec 2019 00:21:33 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Michal Kubecek <mkubecek@...e.cz>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Cc:     Jakub Kicinski <jakub.kicinski@...ronome.com>,
        Jiri Pirko <jiri@...nulli.us>, Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        John Linville <linville@...driver.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/5] rtnetlink: provide permanent hardware
 address in RTM_NEWLINK

On Tue, 2019-12-10 at 00:20 +0100, Johannes Berg wrote:
> On Mon, 2019-12-09 at 20:55 +0100, Michal Kubecek wrote:
> > +	if (memchr_inv(dev->perm_addr, '\0', dev->addr_len) &&
> 
> Why not simply !is_zero_ether_addr()?

Ugh, sorry, ignore me. I need to go sleep instead of looking at patches.

johannes