netdev - Re: [PATCH] virtio: Work around frames incorrectly marked as gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db33800253f071a1cfbb91f413af59e73faa6775.camel@sipsolutions.net>
Date:   Mon, 09 Dec 2019 11:54:46 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     anton.ivanov@...bridgegreys.com, netdev@...r.kernel.org
Cc:     jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-um@...ts.infradead.org, mst@...hat.com
Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso


>  		else if (sinfo->gso_type & SKB_GSO_TCPV6)
>  			hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6;
> -		else
> -			return -EINVAL;
> +		else {
> +			if (skb->data_len == 0)
> +				hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE;


maybe use "else if" like in the before? yes, it's a different type of
condition, but braces look a bit unnatural here to me at least

johannes