netdev - Re: [PATCH V1 net] net: ena: fix napi handler misbehavior when the napi budget is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4903CBE2-8A70-4B47-ABB2-A884C99E3ABF@amazon.com>
Date:   Tue, 10 Dec 2019 11:28:17 +0000
From:   "Belgazal, Netanel" <netanel@...zon.com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        "Machulsky, Zorik" <zorik@...zon.com>,
        "Matushevsky, Alexander" <matua@...zon.com>,
        "Bshara, Saeed" <saeedb@...zon.com>,
        "Wilson, Matt" <msw@...zon.com>,
        "Liguori, Anthony" <aliguori@...zon.com>,
        "Bshara, Nafea" <nafea@...zon.com>,
        "Tzalik, Guy" <gtzalik@...zon.com>,
        "Saidi, Ali" <alisaidi@...zon.com>,
        "Herrenschmidt, Benjamin" <benh@...zon.com>,
        "Kiyanovski, Arthur" <akiyano@...zon.com>
Subject: Re: [PATCH V1 net] net: ena: fix napi handler misbehavior when the
 napi budget is zero

I just did it.

Regards,
Netanel

On 12/9/19, 8:35 PM, "David Miller" <davem@...emloft.net> wrote:

    From: Netanel Belgazal <netanel@...zon.com>
    Date: Sun, 8 Dec 2019 17:30:26 +0000
    
    > In netpoll the napi handler could be called with budget equal to zero.
    > Current ENA napi handler doesn't take that into consideration.
    > 
    > The napi handler handles Rx packets in a do-while loop.
    > Currently, the budget check happens only after decrementing the
    > budget, therefore the napi handler, in rare cases, could run over
    > MAX_INT packets.
    > 
    > In addition to that, this moves all budget related variables to int
    > calculation and stop mixing u32 to avoid ambiguity
    > 
    > Signed-off-by: Netanel Belgazal <netanel@...zon.com>
    
    Bug fixes need to have an appropriate Fixes: tag.
    
    Please repost with that added, thank you.