netdev - Re: [PATCH] ARM: net: bpf: improve endian conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201912102358.E501eN95%lkp@intel.com>
Date:   Tue, 10 Dec 2019 23:55:00 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     kbuild-all@...ts.01.org, Daniel Borkmann <daniel@...earbox.net>,
        Shubham Bansal <illusionist.neo@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: net: bpf: improve endian conversion

Hi Russell,

I love your patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]
[also build test ERROR on bpf/master v5.5-rc1 next-20191209]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Russell-King/ARM-net-bpf-improve-endian-conversion/20191210-011341
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/arm/net/bpf_jit_32.c: In function 'emit_a32_endian':
>> arch/arm/net/bpf_jit_32.c:1263:11: error: 'imm' undeclared (first use in this function)
      switch (imm) {
              ^~~
   arch/arm/net/bpf_jit_32.c:1263:11: note: each undeclared identifier is reported only once for each function it appears in
   arch/arm/net/bpf_jit_32.c:1252:12: warning: unused variable 'tmp2' [-Wunused-variable]
     const s8 *tmp2 = bpf2a32[TMP_REG_2];
               ^~~~

vim +/imm +1263 arch/arm/net/bpf_jit_32.c

  1247	
  1248	static void emit_a32_endian(const s8 dst[], u8 code, s32 bits,
  1249				    struct jit_ctx *ctx)
  1250	{
  1251		const s8 *tmp = bpf2a32[TMP_REG_1];
  1252		const s8 *tmp2 = bpf2a32[TMP_REG_2];
  1253		const s8 *rd;
  1254	
  1255		/* Converting from LE and 64-bit value is a no-op. */
  1256		if (code == BPF_FROM_LE && bits == 64)
  1257			return;
  1258	
  1259		rd = arm_bpf_get_reg64(dst, tmp, ctx);
  1260	
  1261		if (code != BPF_FROM_LE) {
  1262			/* endian swap */
> 1263			switch (imm) {
  1264			case 16:
  1265				emit_rev16(rd[1], rd[1], ctx);
  1266				break;
  1267			case 32:
  1268				emit_rev32(rd[1], rd[1], ctx);
  1269				break;
  1270			case 64:
  1271				emit_rev32(ARM_LR, rd[1], ctx);
  1272				emit_rev32(rd[1], rd[0], ctx);
  1273				emit(ARM_MOV_R(rd[0], ARM_LR), ctx);
  1274				break;
  1275			}
  1276		}
  1277	
  1278		/* zero-extend size to 64-bit */
  1279		switch (imm) {
  1280		case 16:
  1281	#if __LINUX_ARM_ARCH__ < 6
  1282			emit_a32_mov_i(tmp2[1], 0xffff, ctx);
  1283			emit(ARM_AND_R(rd[1], rd[1], tmp2[1]), ctx);
  1284	#else /* ARMv6+ */
  1285			emit(ARM_UXTH(rd[1], rd[1]), ctx);
  1286	#endif
  1287			/* FALLTHROUGH */
  1288		case 32:
  1289			if (!ctx->prog->aux->verifier_zext)
  1290				emit(ARM_MOV_I(rd[0], 0), ctx);
  1291			break;
  1292		}
  1293	
  1294		arm_bpf_put_reg64(dst, rd, ctx);
  1295	}
  1296	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (72111 bytes)