netdev - Re: [PATCH net-next v2 07/14] net: phylink: re-split __phylink_connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191210170611.GM27714@lunn.ch>
Date:   Tue, 10 Dec 2019 18:06:11 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King <rmk+kernel@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 07/14] net: phylink: re-split
 __phylink_connect_phy()

On Mon, Dec 09, 2019 at 03:19:01PM +0000, Russell King wrote:
> In order to support Clause 45 PHYs on SFP+ modules, which have an
> indeterminant phy interface mode, we need to be able to call
> phylink_bringup_phy() with a different interface mode to that used when
> binding the PHY. Reduce __phylink_connect_phy() to an attach operation,
> and move the call to phylink_bringup_phy() to its call sites.
> 
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew