netdev - Re: [PATCH 10/11] net: make socket read/write_iter() honor IOCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191210.113700.2038253518329326443.davem@davemloft.net>
Date:   Tue, 10 Dec 2019 11:37:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     axboe@...nel.dk
Cc:     io-uring@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH 10/11] net: make socket read/write_iter() honor
 IOCB_NOWAIT

From: Jens Axboe <axboe@...nel.dk>
Date: Tue, 10 Dec 2019 08:57:41 -0700

> The socket read/write helpers only look at the file O_NONBLOCK. not
> the iocb IOCB_NOWAIT flag. This breaks users like preadv2/pwritev2
> and io_uring that rely on not having the file itself marked nonblocking,
> but rather the iocb itself.
> 
> Cc: David Miller <davem@...emloft.net>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Jens Axboe <axboe@...nel.dk>

I guess this should be OK:

Acked-by: David S. Miller <davem@...emloft.net>