netdev - Re: [PATCH 4/8] brcmfmac: make errors when setting roaming parameters non-fatal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Dec 2019 03:37:46 +0000
From:   Chi-Hsien Lin <Chi-Hsien.Lin@...ress.com>
To:     Soeren Moch <smoch@....de>, Kalle Valo <kvalo@...eaurora.org>
CC:     Arend van Spriel <arend.vanspriel@...adcom.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        Wright Feng <Wright.Feng@...ress.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "brcm80211-dev-list.pdl@...adcom.com" 
        <brcm80211-dev-list.pdl@...adcom.com>,
        brcm80211-dev-list <brcm80211-dev-list@...ress.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/8] brcmfmac: make errors when setting roaming parameters
 non-fatal



On 12/10/2019 6:38, Soeren Moch wrote:
> 4359 dongles do not support setting roaming parameters (error -52).
> Do not fail the 80211 configuration in this case.
> 
> Signed-off-by: Soeren Moch <smoch@....de>
Acked-by: Chi-Hsien Lin <chi-hsien.lin@...ress.com>

> ---
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Arend van Spriel <arend.vanspriel@...adcom.com>
> Cc: Franky Lin <franky.lin@...adcom.com>
> Cc: Hante Meuleman <hante.meuleman@...adcom.com>
> Cc: Chi-Hsien Lin <chi-hsien.lin@...ress.com>
> Cc: Wright Feng <wright.feng@...ress.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: brcm80211-dev-list.pdl@...adcom.com
> Cc: brcm80211-dev-list@...ress.com
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>   .../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c    | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 5598bbd09b62..0cf13cea1dbe 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -6012,19 +6012,17 @@ static s32 brcmf_dongle_roam(struct brcmf_if *ifp)
>   	roamtrigger[1] = cpu_to_le32(BRCM_BAND_ALL);
>   	err = brcmf_fil_cmd_data_set(ifp, BRCMF_C_SET_ROAM_TRIGGER,
>   				     (void *)roamtrigger, sizeof(roamtrigger));
> -	if (err) {
> +	if (err)
>   		bphy_err(drvr, "WLC_SET_ROAM_TRIGGER error (%d)\n", err);
> -		goto roam_setup_done;
> -	}
> 
>   	roam_delta[0] = cpu_to_le32(WL_ROAM_DELTA);
>   	roam_delta[1] = cpu_to_le32(BRCM_BAND_ALL);
>   	err = brcmf_fil_cmd_data_set(ifp, BRCMF_C_SET_ROAM_DELTA,
>   				     (void *)roam_delta, sizeof(roam_delta));
> -	if (err) {
> +	if (err)
>   		bphy_err(drvr, "WLC_SET_ROAM_DELTA error (%d)\n", err);
> -		goto roam_setup_done;
> -	}
> +
> +	return 0;
> 
>   roam_setup_done:
>   	return err;
> --
> 2.17.1
> 
> .
>