netdev - Re: [PATCH 7/8] brcmfmac: not set mbss in vif if firmware does not support MBSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Dec 2019 03:38:50 +0000
From:   Chi-Hsien Lin <Chi-Hsien.Lin@...ress.com>
To:     Soeren Moch <smoch@....de>, Kalle Valo <kvalo@...eaurora.org>
CC:     Wright Feng <Wright.Feng@...ress.com>,
        Arend van Spriel <arend.vanspriel@...adcom.com>,
        Franky Lin <franky.lin@...adcom.com>,
        Hante Meuleman <hante.meuleman@...adcom.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "brcm80211-dev-list.pdl@...adcom.com" 
        <brcm80211-dev-list.pdl@...adcom.com>,
        brcm80211-dev-list <brcm80211-dev-list@...ress.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 7/8] brcmfmac: not set mbss in vif if firmware does not
 support MBSS



On 12/10/2019 6:38, Soeren Moch wrote:
> From: Wright Feng <wright.feng@...ress.com>
> 
> With RSDB mode, FMAC and firmware are able to create 2 or more AP,
> so we should not set mbss in vif structure if firmware does not
> support MBSS feature.
> 
> Signed-off-by: Wright Feng <wright.feng@...ress.com>
Reviewed-by: Chi-Hsien Lin <chi-hsien.lin@...ress.com>

> ---
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Arend van Spriel <arend.vanspriel@...adcom.com>
> Cc: Franky Lin <franky.lin@...adcom.com>
> Cc: Hante Meuleman <hante.meuleman@...adcom.com>
> Cc: Chi-Hsien Lin <chi-hsien.lin@...ress.com>
> Cc: Wright Feng <wright.feng@...ress.com>
> Cc: linux-wireless@...r.kernel.org
> Cc: brcm80211-dev-list.pdl@...adcom.com
> Cc: brcm80211-dev-list@...ress.com
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> index 9d9dc9195e9e..6eb3064c3721 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> @@ -5363,6 +5363,7 @@ struct brcmf_cfg80211_vif *brcmf_alloc_vif(struct brcmf_cfg80211_info *cfg,
>   	struct brcmf_cfg80211_vif *vif_walk;
>   	struct brcmf_cfg80211_vif *vif;
>   	bool mbss;
> +	struct brcmf_if *ifp = brcmf_get_ifp(cfg->pub, 0);
> 
>   	brcmf_dbg(TRACE, "allocating virtual interface (size=%zu)\n",
>   		  sizeof(*vif));
> @@ -5375,7 +5376,8 @@ struct brcmf_cfg80211_vif *brcmf_alloc_vif(struct brcmf_cfg80211_info *cfg,
> 
>   	brcmf_init_prof(&vif->profile);
> 
> -	if (type == NL80211_IFTYPE_AP) {
> +	if (type == NL80211_IFTYPE_AP &&
> +	    brcmf_feat_is_enabled(ifp, BRCMF_FEAT_MBSS)) {
>   		mbss = false;
>   		list_for_each_entry(vif_walk, &cfg->vif_list, list) {
>   			if (vif_walk->wdev.iftype == NL80211_IFTYPE_AP) {
> --
> 2.17.1
> 
> .
>