lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20191210233421.vnybkzc6noskmsjt@kafai-mbp> Date: Tue, 10 Dec 2019 23:34:24 +0000 From: Martin Lau <kafai@...com> To: Arnd Bergmann <arnd@...db.de> CC: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Randy Dunlap <rdunlap@...radead.org>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>, Quentin Monnet <quentin.monnet@...ronome.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] bpf: Fix build in minimal configurations, again On Tue, Dec 10, 2019 at 09:35:46PM +0100, Arnd Bergmann wrote: > Building with -Werror showed another failure: > > kernel/bpf/btf.c: In function 'btf_get_prog_ctx_type.isra.31': > kernel/bpf/btf.c:3508:63: error: array subscript 0 is above array bounds of 'u8[0]' {aka 'unsigned char[0]'} [-Werror=array-bounds] > ctx_type = btf_type_member(conv_struct) + bpf_ctx_convert_map[prog_type] * 2; > > I don't actually understand why the array is empty, but a similar > fix has addressed a related problem, so I suppose we can do the > same thing here. > > Fixes: ce27709b8162 ("bpf: Fix build in minimal configurations") > Signed-off-by: Arnd Bergmann <arnd@...db.de> > --- > kernel/bpf/btf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c > index 7d40da240891..ed2075884724 100644 > --- a/kernel/bpf/btf.c > +++ b/kernel/bpf/btf.c > @@ -3470,6 +3470,7 @@ static u8 bpf_ctx_convert_map[] = { > [_id] = __ctx_convert##_id, > #include <linux/bpf_types.h> > #undef BPF_PROG_TYPE > + 0, /* avoid empty array */ If bpf_types.h is empty, the prog should have already failed earlier in find_prog_type() in syscall.c, so 0 here should be fine. Acked-by: Martin KaFai Lau <kafai@...com>
Powered by blists - more mailing lists