netdev - Re: [PATCH bpf 0/2] Limit tail calls to 33 in all JIT compilers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Dec 2019 14:00:10 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Paul Chaignon <paul.chaignon@...nge.com>
Cc:     Paul Burton <paulburton@...nel.org>,
        Björn Töpel <bjorn.topel@...il.com>,
        Mahshid Khezri <khezri.mahshid@...il.com>,
        paul.chaignon@...il.com, bpf@...r.kernel.org,
        netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        Andrii Nakryiko <andriin@...com>
Subject: Re: [PATCH bpf 0/2] Limit tail calls to 33 in all JIT compilers

On Mon, Dec 09, 2019 at 07:51:52PM +0100, Paul Chaignon wrote:
> The BPF interpreter and all JIT compilers, except RISC-V's and MIPS',
> enforce a 33-tail calls limit at runtime.  Because of this discrepancy, a
> BPF program can have a different behavior and output depending on whether
> it is interpreted or JIT compiled, or depending on the underlying
> architecture.
> 
> This patchset changes the RISC-V and MIPS JIT compilers to limit tail
> calls to 33 instead of 32.  I have checked other BPF JIT compilers for the
> same discrepancy.
> 
> Paul Chaignon (2):
>   bpf, riscv: limit to 33 tail calls
>   bpf, mips: limit to 33 tail calls
> 
>  arch/mips/net/ebpf_jit.c      | 9 +++++----
>  arch/riscv/net/bpf_jit_comp.c | 4 ++--
>  2 files changed, 7 insertions(+), 6 deletions(-)

Applied, thanks!