netdev - Re: iwlwifi warnings in 5.5-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o8wfeyx5.fsf@toke.dk>
Date:   Wed, 11 Dec 2019 15:09:58 +0100
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Johannes Berg <johannes@...solutions.net>,
        Jens Axboe <axboe@...nel.dk>,
        Emmanuel Grumbach <emmanuel.grumbach@...el.com>,
        Luca Coelho <luciano.coelho@...el.com>,
        "Jason A. Donenfeld" <Jason@...c4.com>,
        Steve French <smfrench@...il.com>
Cc:     "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>
Subject: Re: iwlwifi warnings in 5.5-rc1

Johannes Berg <johannes@...solutions.net> writes:

> ++ others who reported this
>
> On Tue, 2019-12-10 at 13:46 -0700, Jens Axboe wrote:
>
>> ------------[ cut here ]------------
>> STA b4:75:0e:99:1f:e0 AC 2 txq pending airtime underflow: 4294967088, 208
>
> We think this is due to TSO, the change below will disable the AQL again
> for now until we can figure out how to really fix it. I think I'll do
> the equivalent for 5.5 and maybe leave it enabled only for ath10k, or
> something like that ...

If we're doing this on a per-driver basis, let's make it a proper
NL80211_EXT_FEATURE and expose it to userspace; that way users can at
least discover if it's supported on their device. I can send a patch
adding that...

Maybe we should untangle this from airtime_flags completely, since if we
just use the flags people could conceivably end up disabling it by
mistake, couldn't they?

-Toke