netdev - Re: [PATCH V2 net] net: ena: fix napi handler misbehavior when the napi budget is zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191210.175527.1568596418475317538.davem@davemloft.net>
Date:   Tue, 10 Dec 2019 17:55:27 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     netanel@...zon.com
Cc:     netdev@...r.kernel.org, dwmw@...zon.com, zorik@...zon.com,
        matua@...zon.com, saeedb@...zon.com, msw@...zon.com,
        aliguori@...zon.com, nafea@...zon.com, gtzalik@...zon.com,
        alisaidi@...zon.com, benh@...zon.com, akiyano@...zon.com
Subject: Re: [PATCH V2 net] net: ena: fix napi handler misbehavior when the
 napi budget is zero

From: Netanel Belgazal <netanel@...zon.com>
Date: Tue, 10 Dec 2019 11:27:44 +0000

> In netpoll the napi handler could be called with budget equal to zero.
> Current ENA napi handler doesn't take that into consideration.
> 
> The napi handler handles Rx packets in a do-while loop.
> Currently, the budget check happens only after decrementing the
> budget, therefore the napi handler, in rare cases, could run over
> MAX_INT packets.
> 
> In addition to that, this moves all budget related variables to int
> calculation and stop mixing u32 to avoid ambiguity
> 
> Signed-off-by: Netanel Belgazal <netanel@...zon.com>
> Fixes: 1738cd3ed342 ("net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)")

Please place the Fixes: tag first in the list of tags next time.

Applied and queued up for -stable, thanks.