netdev - Re: [PATCH net-next 6/9] ipv4: Handle route deletion notification during flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7ad891f6-a096-2795-2e7f-5eefc710503b@gmail.com>
Date:   Wed, 11 Dec 2019 10:46:11 -0700
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...sch.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, jiri@...lanox.com, roopa@...ulusnetworks.com,
        mlxsw@...lanox.com, Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 6/9] ipv4: Handle route deletion notification
 during flush

On 12/10/19 10:23 AM, Ido Schimmel wrote:
> From: Ido Schimmel <idosch@...lanox.com>
> 
> In a similar fashion to previous patch, when a route is deleted as part
> of table flushing, promote the next route in the list, if exists.
> Otherwise, simply emit a delete notification.

I am not following your point on a flush. If all routes are getting
deleted, why do you need to promote the next one in the list?

> 
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> ---
>  net/ipv4/fib_trie.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c
> index 2d338469d4f2..60947a44d363 100644
> --- a/net/ipv4/fib_trie.c
> +++ b/net/ipv4/fib_trie.c
> @@ -1995,6 +1995,8 @@ int fib_table_flush(struct net *net, struct fib_table *tb, bool flush_all)
>  				continue;
>  			}
>  
> +			fib_notify_alias_delete(net, n->key, &n->leaf, fa,
> +						NULL);
>  			call_fib_entry_notifiers(net, FIB_EVENT_ENTRY_DEL,
>  						 n->key,
>  						 KEYLENGTH - fa->fa_slen, fa,
>