netdev - Re: [PATCH nf-next 3/7] netfilter: nft_tunnel: no need to call htons() when dumping ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191211220637.bsgevf3yx2zq7rcl@salvia>
Date:   Wed, 11 Dec 2019 23:06:37 +0100
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>,
        netfilter-devel@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH nf-next 3/7] netfilter: nft_tunnel: no need to call
 htons() when dumping ports

On Wed, Dec 11, 2019 at 10:53:12PM +0100, Pablo Neira Ayuso wrote:
> On Sun, Dec 08, 2019 at 12:41:33PM +0800, Xin Long wrote:
> > info->key.tp_src and tp_dst are __be16, when using nla_put_be16()
> > to dump them, htons() is not needed, so remove it in this patch.
> > 
> > Signed-off-by: Xin Long <lucien.xin@...il.com>
> > ---
> >  net/netfilter/nft_tunnel.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/net/netfilter/nft_tunnel.c b/net/netfilter/nft_tunnel.c
> > index d9d6c0d..e1184fa 100644
> > --- a/net/netfilter/nft_tunnel.c
> > +++ b/net/netfilter/nft_tunnel.c
> > @@ -502,8 +502,8 @@ static int nft_tunnel_opts_dump(struct sk_buff *skb,
> >  static int nft_tunnel_ports_dump(struct sk_buff *skb,
> >  				 struct ip_tunnel_info *info)
> >  {
> > -	if (nla_put_be16(skb, NFTA_TUNNEL_KEY_SPORT, htons(info->key.tp_src)) < 0 ||
> > -	    nla_put_be16(skb, NFTA_TUNNEL_KEY_DPORT, htons(info->key.tp_dst)) < 0)
> > +	if (nla_put_be16(skb, NFTA_TUNNEL_KEY_SPORT, info->key.tp_src) < 0 ||
> > +	    nla_put_be16(skb, NFTA_TUNNEL_KEY_DPORT, info->key.tp_dst) < 0)
> 
> info->key.tp_src is already in __be16 as you describe. So I would take
> this as a consistency fix. I would take this as a fix.

I mean, I think this is worth fixing it indeed.