netdev - Re: [PATCH] Fix tx_table init in rndis_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191211.142211.1624810442420026092.davem@davemloft.net>
Date:   Wed, 11 Dec 2019 14:22:11 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     haiyangz@...rosoft.com
Cc:     sashal@...nel.org, linux-hyperv@...r.kernel.org,
        netdev@...r.kernel.org, kys@...rosoft.com, sthemmin@...rosoft.com,
        olaf@...fle.de, vkuznets@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix tx_table init in rndis_set_subchannel()

From: Haiyang Zhang <haiyangz@...rosoft.com>
Date: Wed, 11 Dec 2019 13:59:03 -0800

> Host can provide send indirection table messages anytime after RSS is
> enabled by calling rndis_filter_set_rss_param(). So the host provided
> table values may be overwritten by the initialization in
> rndis_set_subchannel().
> 
> To prevent this problem, move the tx_table initialization before calling
> rndis_filter_set_rss_param().
> 
> Fixes: a6fb6aa3cfa9 ("hv_netvsc: Set tx_table to equal weight after subchannels open")
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>

Please format your subject lines properly.

	[PATCH $version $GIT_TREE] $subsystem_prefix: $description

Even the Fixes: tag had the proper subsystem prefix in it.

So your next posting must be of the form:

	[PATCH v2 net] hv_netvsc: Fix tx_table init in rndis_set_subchannel().