lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <e40b9299-fd5c-5f62-0c5c-91f254c7a895@pensando.io> Date: Tue, 10 Dec 2019 16:39:41 -0800 From: Shannon Nelson <snelson@...sando.io> To: Parav Pandit <parav@...lanox.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net> Subject: Re: [PATCH net-next 2/2] ionic: support sr-iov operations On 12/10/19 3:25 PM, Parav Pandit wrote: > On 12/10/2019 4:54 PM, Shannon Nelson wrote: >> Add the netdev ops for managing VFs. Since most of the >> management work happens in the NIC firmware, the driver becomes >> mostly a pass-through for the network stack commands that want >> to control and configure the VFs. >> >> We also tweak ionic_station_set() a little to allow for >> the VFs that start off with a zero'd mac address. >> >> Signed-off-by: Shannon Nelson <snelson@...sando.io> >> --- >> drivers/net/ethernet/pensando/ionic/ionic.h | 16 +- >> .../ethernet/pensando/ionic/ionic_bus_pci.c | 75 +++++++ >> .../net/ethernet/pensando/ionic/ionic_dev.c | 61 ++++++ >> .../net/ethernet/pensando/ionic/ionic_dev.h | 7 + >> .../net/ethernet/pensando/ionic/ionic_lif.c | 188 +++++++++++++++++- >> .../net/ethernet/pensando/ionic/ionic_lif.h | 6 + >> .../net/ethernet/pensando/ionic/ionic_main.c | 4 + >> 7 files changed, 349 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h b/drivers/net/ethernet/pensando/ionic/ionic.h >> index 98e102af7756..d4cf58da8d13 100644 >> --- a/drivers/net/ethernet/pensando/ionic/ionic.h >> +++ b/drivers/net/ethernet/pensando/ionic/ionic.h >> @@ -12,7 +12,7 @@ struct ionic_lif; >> >> #define IONIC_DRV_NAME "ionic" >> #define IONIC_DRV_DESCRIPTION "Pensando Ethernet NIC Driver" >> -#define IONIC_DRV_VERSION "0.18.0-k" >> +#define IONIC_DRV_VERSION "0.20.0-k" >> >> #define PCI_VENDOR_ID_PENSANDO 0x1dd8 >> >> @@ -25,6 +25,18 @@ struct ionic_lif; >> >> #define DEVCMD_TIMEOUT 10 >> >> +struct ionic_vf { >> + u16 index; >> + u8 macaddr[6]; >> + __le32 maxrate; >> + __le16 vlanid; >> + u8 spoofchk; >> + u8 trusted; >> + u8 linkstate; >> + dma_addr_t stats_pa; >> + struct ionic_lif_stats stats; >> +}; >> + >> struct ionic { >> struct pci_dev *pdev; >> struct device *dev; >> @@ -46,6 +58,8 @@ struct ionic { >> DECLARE_BITMAP(intrs, IONIC_INTR_CTRL_REGS_MAX); >> struct work_struct nb_work; >> struct notifier_block nb; >> + int num_vfs; > Please drop num_vfs and use pci_num_vf() in ionic_get_vf_config() and > other friend functions. Sure. >> + struct ionic_vf **vf; >> struct timer_list watchdog_timer; >> int watchdog_period; >> }; >> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c >> index 9a9ab8cb2cb3..fe4efe12b50b 100644 >> --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c >> +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c >> @@ -274,11 +274,86 @@ static void ionic_remove(struct pci_dev *pdev) >> ionic_devlink_free(ionic); >> } >> >> +static int ionic_sriov_configure(struct pci_dev *pdev, int num_vfs) >> +{ >> + struct ionic *ionic = pci_get_drvdata(pdev); >> + struct device *dev = ionic->dev; >> + unsigned int size; >> + int i, err = 0; >> + >> + if (!ionic_is_pf(ionic)) >> + return -ENODEV; >> + > This check is already done by pci core kernel. No need for ionic driver > to do this. If SR-IOV capability is not enabled, it won't reach here. Got it > >> + if (num_vfs > 0) { >> + err = pci_enable_sriov(pdev, num_vfs); >> + if (err) { >> + dev_err(&pdev->dev, "Cannot enable SRIOV: %d\n", err); >> + return err; >> + } >> + >> + size = sizeof(struct ionic_vf *) * num_vfs; >> + ionic->vf = kzalloc(size, GFP_KERNEL); > Please use kcalloc() Sure Thanks for the comments, sln
Powered by blists - more mailing lists