netdev - RE: [PATCH net-next 1/3] net: skb_mpls_push() modified to allow MPLS header push at start of packet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR07MB440807A1042502E67507A55BED5A0@DB6PR07MB4408.eurprd07.prod.outlook.com>
Date:   Wed, 11 Dec 2019 03:06:25 +0000
From:   "Varghese, Martin (Nokia - IN/Bangalore)" <martin.varghese@...ia.com>
To:     David Miller <davem@...emloft.net>,
        "martinvarghesenokia@...il.com" <martinvarghesenokia@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pshelar@....org" <pshelar@....org>,
        "Drennan, Scott (Nokia - US/Mountain View)" <scott.drennan@...ia.com>,
        "jbenc@...hat.com" <jbenc@...hat.com>
Subject: RE: [PATCH net-next 1/3] net: skb_mpls_push() modified to allow MPLS
 header push at start of packet.

Oops Typo, will fix it. thanks

-----Original Message-----
From: David Miller <davem@...emloft.net> 
Sent: Wednesday, December 11, 2019 7:14 AM
To: martinvarghesenokia@...il.com
Cc: netdev@...r.kernel.org; pshelar@....org; Drennan, Scott (Nokia - US/Mountain View) <scott.drennan@...ia.com>; jbenc@...hat.com; Varghese, Martin (Nokia - IN/Bangalore) <martin.varghese@...ia.com>
Subject: Re: [PATCH net-next 1/3] net: skb_mpls_push() modified to allow MPLS header push at start of packet.

From: Martin Varghese <martinvarghesenokia@...il.com>
Date: Tue, 10 Dec 2019 13:45:52 +0530

> @@ -5472,12 +5472,15 @@ static void skb_mod_eth_type(struct sk_buff 
> *skb, struct ethhdr *hdr,  }
>  
>  /**
> - * skb_mpls_push() - push a new MPLS header after the mac header
> + * skb_mpls_push() - push a new MPLS header after mac_len bytes from start of
> + *                   the packet
>   *
>   * @skb: buffer
>   * @mpls_lse: MPLS label stack entry to push
>   * @mpls_proto: ethertype of the new MPLS header (expects 0x8847 or 0x8848)
>   * @mac_len: length of the MAC header
> + * #ethernet: flag to indicate if the resulting packet after skb_mpls_push is
> + *            ethernet

Why "#ethernet" and not "@ethernet" to refer to this argument?