netdev - Re: [PATCH] staging: qlge: Fix multiple WARNING and CHECK relating to formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191211073136.GB397938@kroah.com>
Date:   Wed, 11 Dec 2019 08:31:36 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Scott Schafer <schaferjscott@...il.com>
Cc:     devel@...verdev.osuosl.org, GR-Linux-NIC-Dev@...vell.com,
        Manish Chopra <manishc@...vell.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: qlge: Fix multiple WARNING and CHECK relating
 to formatting

On Tue, Dec 10, 2019 at 07:47:59PM -0600, Scott Schafer wrote:
> CHECK: Please don't use multiple blank lines
> CHECK: Blank lines aren't necessary before a close brace '}'
> CHECK: Blank lines aren't necessary after an open brace '{'
> WARNING: Missing a blank line after declarations
> CHECK: No space is necessary after a cast
> CHECK: braces {} should be used on all arms of this statement
> CHECK: Unbalanced braces around else statement
> WARNING: please, no space before tabs
> CHECK: spaces preferred around that '/' (ctx:VxV)
> CHECK: spaces preferred around that '+' (ctx:VxV)
> CHECK: spaces preferred around that '%' (ctx:VxV)
> CHECK: spaces preferred around that '|' (ctx:VxV)
> CHECK: spaces preferred around that '*' (ctx:VxV)
> WARNING: Unnecessary space before function pointer arguments
> WARNING: please, no spaces at the start of a line
> WARNING: Block comments use a trailing */ on a separate line
> ERROR: trailing whitespace
> 
> In files qlge.h, qlge_dbg.c, qlge_ethtool.c, qlge_main.c, and qlge_mpi.c
> 
> Signed-off-by: Scott Schafer <schaferjscott@...il.com>
> ---
>  drivers/staging/qlge/qlge.h         |  45 ++++++-------
>  drivers/staging/qlge/qlge_dbg.c     |  41 ++++++-----
>  drivers/staging/qlge/qlge_ethtool.c |  20 ++++--
>  drivers/staging/qlge/qlge_main.c    | 101 ++++++++++++++--------------
>  drivers/staging/qlge/qlge_mpi.c     |  37 +++++-----
>  5 files changed, 125 insertions(+), 119 deletions(-)

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot