netdev - Re: [PATCH net-next v2] net: bridge: add STP xstats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 11 Dec 2019 20:02:37 -0500
From:   Vivien Didelot <vivien.didelot@...il.com>
To:     David Miller <davem@...emloft.net>
Cc:     nikolay@...ulusnetworks.com, dsahern@...il.com,
        roopa@...ulusnetworks.com, netdev@...r.kernel.org,
        bridge@...ts.linux-foundation.org, stephen@...workplumber.org
Subject: Re: [PATCH net-next v2] net: bridge: add STP xstats

Hi David,

On Wed, 11 Dec 2019 14:16:58 -0800 (PST), David Miller <davem@...emloft.net> wrote:
> > To be more precise, what I don't get is that when
> > I move the BRIDGE_XSTATS_STP definition *after* BRIDGE_XSTATS_PAD, the STP
> > xstats don't show up anymore in iproute2.
> 
> Because you ahve to recompile iproute2 so that it uses the corrected value
> in the kernel header, did you do that?

Meh you were correct, my rebuild didn't pick up the header change :-/

I also moved the STP xstats copy below the mcast xstats copy to be consistent
with the order. I'll respin right away.


Thanks,

	Vivien