netdev - Re: [BUG] mv88e6xxx: tx regression in v5.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 19:32:18 +0100
From:   Marek Behun <marek.behun@....cz>
To:     Baruch Siach <baruch@...s.co.il>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev@...r.kernel.org,
        Denis Odintsov <d.odintsov@...viangames.com>,
        Hubert Feurstein <h.feurstein@...il.com>
Subject: Re: [BUG] mv88e6xxx: tx regression in v5.3

On Thu, 12 Dec 2019 20:17:29 +0200
Baruch Siach <baruch@...s.co.il> wrote:

> This is not enough to fix v5.4, though. Commit 7a3007d22e8dc ("net: dsa: 
> mv88e6xxx: fully support SERDES on Topaz family") breaks switch Tx on SolidRun 
> Clearfog GT-8K in much the same way. I could not easily revert 7a3007d22e8dc 
> on top of v5.4, but this is enough to make Tx work again with v5.4:
> 
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
> index 7b5b73499e37..e7e6400a994e 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -3191,7 +3191,6 @@ static const struct mv88e6xxx_ops mv88e6141_ops = {
>  	.port_disable_pri_override = mv88e6xxx_port_disable_pri_override,
>  	.port_link_state = mv88e6352_port_link_state,
>  	.port_get_cmode = mv88e6352_port_get_cmode,
> -	.port_set_cmode = mv88e6341_port_set_cmode,
>  	.port_setup_message_port = mv88e6xxx_setup_message_port,
>  	.stats_snapshot = mv88e6390_g1_stats_snapshot,
>  	.stats_set_histogram = mv88e6095_g1_stats_set_histogram,
> 
> Marek, do you have any idea how to properly fix this?
> 
> Thanks,
> baruch
> 

Hi Baruch,

can you tell on which port the port_set_cmode is called when things
break? Because if it is other than port 5, than method
mv88e6341_port_set_cmode does nothing. If it is port 5, do you have cpu
connected to the switch via port 5? What phy mode?

Marek