netdev - Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be used on all arms of this statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 12 Dec 2019 11:25:03 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     schaferjscott@...il.com
Cc:     dan.carpenter@...cle.com, gregkh@...uxfoundation.org,
        devel@...verdev.osuosl.org, GR-Linux-NIC-Dev@...vell.com,
        manishc@...vell.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 11/23] staging: qlge: Fix CHECK: braces {} should be
 used on all arms of this statement

From: Scott Schafer <schaferjscott@...il.com>
Date: Thu, 12 Dec 2019 09:02:00 -0600

> On Thu, Dec 12, 2019 at 03:12:06PM +0300, Dan Carpenter wrote:
>> On Wed, Dec 11, 2019 at 12:12:40PM -0600, Scott Schafer wrote:
>> > @@ -351,8 +352,9 @@ static int ql_aen_lost(struct ql_adapter *qdev, struct mbox_params *mbcp)
>> >  	mbcp->out_count = 6;
>> >  
>> >  	status = ql_get_mb_sts(qdev, mbcp);
>> > -	if (status)
>> > +	if (status) {
>> >  		netif_err(qdev, drv, qdev->ndev, "Lost AEN broken!\n");
>> > +	}
>> >  	else {
>> 
>> The close } should be on the same line as the else.
>> 
>> >  		int i;
>> >  
>> 
>> regards,
>> dan carpenter
> 
> this was fixed in patch 22

It should not be introduced in the first place.  Therefore it needs to be dealt with
in this patch.