netdev - Re: [PATCH v3 05/20] RDMA/irdma: Add driver framework definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191212091238.GA1373130@kroah.com>
Date:   Thu, 12 Dec 2019 10:12:38 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "Saleem, Shiraz" <shiraz.saleem@...el.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Ismail, Mustafa" <mustafa.ismail@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "parav@...lanox.com" <parav@...lanox.com>
Subject: Re: [PATCH v3 05/20] RDMA/irdma: Add driver framework definitions

On Thu, Dec 12, 2019 at 10:39:04AM +0200, Leon Romanovsky wrote:
> On Thu, Dec 12, 2019 at 01:40:27AM +0000, Saleem, Shiraz wrote:
> > > Subject: Re: [PATCH v3 05/20] RDMA/irdma: Add driver framework definitions
> 
> <...>
> 
> > >
> > > > +		ldev->ops->reg_for_notification(ldev, &events);
> > > > +	dev_info(rfdev_to_dev(dev), "IRDMA VSI Open Successful");
> > >
> > > Lets not do this kind of logging..
> > >
> >
> > There is some dev_info which should be cleaned up to dev_dbg.
> > But logging this info is useful to know that this functions VSI (and associated ibdev)
> > is up and reading for RDMA traffic.
> > Is info logging to be avoided altogether?
> 
> Will function tracer (ftrace) output be sufficient here?
> https://www.kernel.org/doc/html/latest/trace/ftrace.html

Yes it should.