lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Dec 2019 12:11:18 -0500 From: Steven Rostedt <rostedt@...dmis.org> To: Alexei Starovoitov <alexei.starovoitov@...il.com> Cc: Jiri Olsa <jolsa@...hat.com>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Toke Høiland-Jørgensen <toke@...hat.com>, Andrii Nakryiko <andrii.nakryiko@...il.com>, Jiri Olsa <jolsa@...nel.org>, Arnaldo Carvalho de Melo <acme@...nel.org>, lkml <linux-kernel@...r.kernel.org>, Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>, Ingo Molnar <mingo@...nel.org>, Namhyung Kim <namhyung@...nel.org>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jesper Dangaard Brouer <brouer@...hat.com>, Daniel Borkmann <daniel@...earbox.net>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, Andrii Nakryiko <andriin@...com>, Quentin Monnet <quentin.monnet@...ronome.com> Subject: Re: [RFC] btf: Some structs are doubled because of struct ring_buffer On Fri, 13 Dec 2019 08:51:57 -0800 Alexei Starovoitov <alexei.starovoitov@...il.com> wrote: > It had two choices. Both valid. I don't know why gdb picked this one. > So yeah I think renaming 'ring_buffer' either in ftrace or in perf would be > good. I think renaming ftrace one would be better, since gdb picked perf one > for whatever reason. Because of the sort algorithm. But from a technical perspective, the ring buffer that ftrace uses is generic, where the perf ring buffer can only be used for perf. Call it "event_ring_buffer" or whatever, but it's not generic and should not have a generic name. -- Steve
Powered by blists - more mailing lists