netdev - Re: [PATCH v3 bpf-next 09/11] selftests/bpf: add batch ops testing for htab and htab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8944148-1f66-f367-04d8-93d30997d123@fb.com>
Date:   Fri, 13 Dec 2019 18:40:48 +0000
From:   Yonghong Song <yhs@...com>
To:     Brian Vazquez <brianvv@...gle.com>,
        Brian Vazquez <brianvv.kernel@...il.com>,
        Alexei Starovoitov <ast@...nel.org>,
        "Daniel Borkmann" <daniel@...earbox.net>,
        "David S . Miller" <davem@...emloft.net>
CC:     Stanislav Fomichev <sdf@...gle.com>,
        Petar Penkov <ppenkov@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>
Subject: Re: [PATCH v3 bpf-next 09/11] selftests/bpf: add batch ops testing
 for htab and htab_percpu map



On 12/11/19 2:33 PM, Brian Vazquez wrote:
> From: Yonghong Song <yhs@...com>
> 
> Tested bpf_map_lookup_batch(), bpf_map_lookup_and_delete_batch(),
> bpf_map_update_batch(), and bpf_map_delete_batch() functionality.
>    $ ./test_maps
>      ...
>        test_htab_map_batch_ops:PASS
>        test_htab_percpu_map_batch_ops:PASS
>      ...
> 
> Signed-off-by: Yonghong Song <yhs@...com>
> Signed-off-by: Brian Vazquez <brianvv@...gle.com>
> ---
>   .../bpf/map_tests/htab_map_batch_ops.c        | 269 ++++++++++++++++++
>   1 file changed, 269 insertions(+)
>   create mode 100644 tools/testing/selftests/bpf/map_tests/htab_map_batch_ops.c
> 
> diff --git a/tools/testing/selftests/bpf/map_tests/htab_map_batch_ops.c b/tools/testing/selftests/bpf/map_tests/htab_map_batch_ops.c
> new file mode 100644
> index 0000000000000..dabc4d420a10e
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/map_tests/htab_map_batch_ops.c
> @@ -0,0 +1,269 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2019 Facebook  */
> +#include <stdio.h>
> +#include <errno.h>
> +#include <string.h>
> +
> +#include <bpf/bpf.h>
> +#include <bpf/libbpf.h>
> +
> +#include <bpf_util.h>
> +#include <test_maps.h>
> +
> +static void map_batch_update(int map_fd, __u32 max_entries, int *keys,
> +			     void *values, bool is_pcpu)
> +{
> +	typedef BPF_DECLARE_PERCPU(int, value);
> +	int i, j, err;
> +	value *v;

We can initialize the above 'v' to 'v = NULL'.
Some compiler may not be smart enough to find out 'v' is always initialized.

> +
> +	if (is_pcpu)
> +		v = (value *)values;
> +
> +	for (i = 0; i < max_entries; i++) {
> +		keys[i] = i + 1;
> +		if (is_pcpu)
> +			for (j = 0; j < bpf_num_possible_cpus(); j++)
> +				bpf_percpu(v[i], j) = i + 2 + j;
> +		else
> +			((int *)values)[i] = i + 2;
> +	}
> +
> +	err = bpf_map_update_batch(map_fd, keys, values, &max_entries, 0, 0);
> +	CHECK(err, "bpf_map_update_batch()", "error:%s\n", strerror(errno));
> +}
> +
[...]