netdev - Re: [PATCH bpf v2] bpf: clear skb->tstamp in bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQKmNifGQzh+gTL3vvxuEBR9et8-Oj++OWKgY4pfYc-=sQ@mail.gmail.com>
Date:   Fri, 13 Dec 2019 15:25:25 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Eric Dumazet <eric.dumazet@...il.com>
Cc:     Lorenz Bauer <lmb@...udflare.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Network Development <netdev@...r.kernel.org>,
        bpf <bpf@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        kernel-team <kernel-team@...udflare.com>
Subject: Re: [PATCH bpf v2] bpf: clear skb->tstamp in bpf_redirect when necessary

On Fri, Dec 13, 2019 at 1:09 PM Eric Dumazet <eric.dumazet@...il.com> wrote:
>
>
>
> On 12/13/19 10:08 AM, Lorenz Bauer wrote:
> > Redirecting a packet from ingress to egress by using bpf_redirect
> > breaks if the egress interface has an fq qdisc installed. This is the same
> > problem as fixed in 'commit 8203e2d844d3 ("net: clear skb->tstamp in forwarding paths")
> >
> > Clear skb->tstamp when redirecting into the egress path.
> >
> > Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time.")
> > Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
> > Signed-off-by: Lorenz Bauer <lmb@...udflare.com>
> > ---
> >  net/core/filter.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/net/core/filter.c b/net/core/filter.c
> > index f1e703eed3d2..d914257763b5 100644
> > --- a/net/core/filter.c
> > +++ b/net/core/filter.c
> > @@ -2055,6 +2055,7 @@ static inline int __bpf_tx_skb(struct net_device *dev, struct sk_buff *skb)
> >       }
> >
> >       skb->dev = dev;
> > +     skb->tstamp = 0;
> >
> >       dev_xmit_recursion_inc();
> >       ret = dev_queue_xmit(skb);
> >
>
> Thanks !
>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Applied. Thanks