netdev - Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev related code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cefcf3a4-fc10-d62a-cac9-81f0e47710a8@suse.com>
Date:   Fri, 13 Dec 2019 06:40:38 +0100
From:   Jürgen Groß <jgross@...e.com>
To:     David Miller <davem@...emloft.net>, pdurrant@...zon.com
Cc:     xen-devel@...ts.xenproject.org, wei.liu@...nel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [Xen-devel] [PATCH net-next] xen-netback: get rid of old udev
 related code

On 12.12.19 20:05, David Miller wrote:
> From: Paul Durrant <pdurrant@...zon.com>
> Date: Thu, 12 Dec 2019 13:54:06 +0000
> 
>> In the past it used to be the case that the Xen toolstack relied upon
>> udev to execute backend hotplug scripts. However this has not been the
>> case for many releases now and removal of the associated code in
>> xen-netback shortens the source by more than 100 lines, and removes much
>> complexity in the interaction with the xenstore backend state.
>>
>> NOTE: xen-netback is the only xenbus driver to have a functional uevent()
>>        method. The only other driver to have a method at all is
>>        pvcalls-back, and currently pvcalls_back_uevent() simply returns 0.
>>        Hence this patch also facilitates further cleanup.
>>
>> Signed-off-by: Paul Durrant <pdurrant@...zon.com>
> 
> If userspace ever used this stuff, I seriously doubt you can remove this
> even if it hasn't been used in 5+ years.

Hmm, depends.

This has been used by Xen tools in dom0 only. If the last usage has been
in a Xen version which is no longer able to run with current Linux in
dom0 it could be removed. But I guess this would have to be a rather old
version of Xen (like 3.x?).

Paul, can you give a hint since which Xen version the toolstack no
longer relies on udev to start the hotplug scripts?


Juergen