netdev - Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 13 Dec 2019 08:37:17 +0100
From:   Marcel Holtmann <marcel@...tmann.org>
To:     Rocky Liao <rjliao@...eaurora.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Johan Hedberg <johan.hedberg@...il.com>,
        netdev@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, bgodavar@...eaurora.org,
        linux-bluetooth-owner@...r.kernel.org
Subject: Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree
 bindings for QCA6390

Hi Rocky,

>>> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
>>> Signed-off-by: Rocky Liao <rjliao@...eaurora.org>
>>> ---
>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> index 68b67d9db63a..87b7f9d22414 100644
>>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> @@ -10,6 +10,7 @@ device the slave device is attached to.
>>> Required properties:
>>> - compatible: should contain one of the following:
>>>   * "qcom,qca6174-bt"
>>> +   * "qcom,qca6390-bt"
>>>   * "qcom,wcn3990-bt"
>>>   * "qcom,wcn3998-bt"
>> now I am confused. Is this a DT platform or ACPI or both?
> We need to support both, should I update ACPI part in this doc as well?

this patch is fine the, but the other one would be better if you split it in DT and ACPI support.

Regards

Marcel