netdev - RE: [EXT] Re: LRO/HW_GRO is not disabled when native xdp is installed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR18MB3379AC23267423E0CE9EEA05AB540@BY5PR18MB3379.namprd18.prod.outlook.com>
Date:   Fri, 13 Dec 2019 09:45:32 +0000
From:   Manish Chopra <manishc@...vell.com>
To:     Michael Chan <michael.chan@...adcom.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [EXT] Re: LRO/HW_GRO is not disabled when native xdp is installed

Hi Michael,

> -----Original Message-----
> From: Michael Chan <michael.chan@...adcom.com>
> Sent: Friday, December 13, 2019 9:41 AM
> To: Manish Chopra <manishc@...vell.com>
> Cc: netdev@...r.kernel.org
> Subject: [EXT] Re: LRO/HW_GRO is not disabled when native xdp is installed
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Thu, Dec 12, 2019 at 7:13 PM Manish Chopra <manishc@...vell.com>
> wrote:
> 
> > When attaching native xdp program, device's aggregation features (i.e
> LRO/HW_GRO) are not getting disabled.
> > They seems to be getting disabled only in case of generic xdp install,
> > not in case of native/driver mode xdp,
> 
> That sounds right.  For bnxt, when an xdp program is attached, the driver
> will run in a special paging mode that won't support LRO or hardware GRO.
> So they are automatically turned off.  Isn't that the case for your device as
> well?

It used to be the case for our devices as well long back. but after the commit 18c602dee4726 ("qede: Use NETIF_F_GRO_HW")
that part was removed from our driver and commit 56f5aa77cdad1 ("net: Disable GRO_HW when generic XDP is installed on a device")
was added to achieve the same instead of individual driver doing it, but it wasn't caught that time why later commit only does for generic xdp,
not for native xdp. So today when native xdp is attached to our device, HW GRO aggregation remains enabled on our device.
Please let me know if that fix is good enough to be posted. Will test it out and post.

Thanks,
Manish