netdev - Re: crash in __xfrm_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191213111322.GE26283@gauss3.secunet.de>
Date:   Fri, 13 Dec 2019 12:13:22 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Florian Westphal <fw@...len.de>
CC:     Josh Hunt <johunt@...mai.com>, <herbert@...dor.apana.org.au>,
        David Miller <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>
Subject: Re: crash in __xfrm_state_lookup on 4.19 LTS

On Fri, Dec 13, 2019 at 11:25:12AM +0100, Florian Westphal wrote:
> Steffen Klassert <steffen.klassert@...unet.com> wrote:
> > 
> > We destroy the states with a workqueue by doing schedule_work().
> > I think we should better use call_rcu to make sure that a
> > rcu grace period has elapsed before the states are destroyed.
> 
> xfrm_state_gc_task calls synchronize_rcu after stealing the gc list and
> before destroying those states, so I don't think this is a problem.

That's true, I've missed this. In that case, I don't
have an idea what is the root cause of these crashes.
We need to find a way to reproduce it.