netdev - Re: [PATCH net 0/3] tcp: take care of empty skbs in write queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191214100618.43e39031@cakuba.netronome.com>
Date:   Sat, 14 Dec 2019 10:06:18 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Neal Cardwell <ncardwell@...gle.com>,
        Jason Baron <jbaron@...mai.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net 0/3] tcp: take care of empty skbs in write queue

On Thu, 12 Dec 2019 12:55:28 -0800, Eric Dumazet wrote:
> We understood recently that TCP sockets could have an empty
> skb at the tail of the write queue, leading to various problems.
> 
> This patch series :
> 
> 1) Make sure we do not send an empty packet since this
>    was unintended and causing crashes in old kernels.
> 
> 2) Change tcp_write_queue_empty() to not be fooled by
>    the presence of an empty skb.
> 
> 3) Fix a bug that could trigger suboptimal epoll()
>    application behavior under memory pressure.

Applied, thank you!

I've only queued patch 1 for stable/all, please let me know if I should
also queue 2 and/or 3.