netdev - Re: [PATCH v3 bpf-next 12/17] libbpf: add BPF object skeleton support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzboMHcjv8Jz4A16RvJDPp-1+zs+VtdoAM6tqXChM8igQQ@mail.gmail.com>
Date:   Fri, 13 Dec 2019 17:07:35 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 12/17] libbpf: add BPF object skeleton support

On Fri, Dec 13, 2019 at 3:59 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Fri, Dec 13, 2019 at 02:32:09PM -0800, Andrii Nakryiko wrote:
> > Add new set of APIs, allowing to open/load/attach BPF object through BPF
> > object skeleton, generated by bpftool for a specific BPF object file. All the
> > xxx_skeleton() APIs wrap up corresponding bpf_object_xxx() APIs, but
> > additionally also automate map/program lookups by name, global data
> > initialization and mmap()-ing, etc.  All this greatly improves and simplifies
> > userspace usability of working with BPF programs. See follow up patches for
> > examples.
> >
> > Acked-by: Martin KaFai Lau <kafai@...com>
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
> ...
> > +int bpf_object__open_skeleton(struct bpf_object_skeleton *s,
> > +                           const struct bpf_object_open_opts *opts);
> > +int bpf_object__load_skeleton(struct bpf_object_skeleton *s);
> > +int bpf_object__attach_skeleton(struct bpf_object_skeleton *s);
> > +void bpf_object__detach_skeleton(struct bpf_object_skeleton *s);
> > +void bpf_object__destroy_skeleton(struct bpf_object_skeleton *s);
>
> libbpf.map and LIBBPF_API update for them is missing ?
> The intent was to expose them as stable libbpf api, right?
>

Yeah, my bad, forgot to add LIBBPF_API.