netdev - Re: [PATCH v3 bpf-next 2/4] libbpf: support libbpf-provided extern variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzZO0RH4sYcEznEH7yacB+343NNTOtcCs6Xi9GHqO4EnsA@mail.gmail.com>
Date:   Fri, 13 Dec 2019 17:20:55 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Alexei Starovoitov <ast@...com>
Cc:     Andrii Nakryiko <andriin@...com>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        Kernel Team <Kernel-team@...com>
Subject: Re: [PATCH v3 bpf-next 2/4] libbpf: support libbpf-provided extern variables

On Fri, Dec 13, 2019 at 4:20 PM Alexei Starovoitov <ast@...com> wrote:
>
> On 12/13/19 3:51 PM, Andrii Nakryiko wrote:
> >   static int
> >   bpf_object__init_internal_map(struct bpf_object *obj, enum libbpf_map_type type,
> > -                           int sec_idx, Elf_Data *data)
> > +                           int sec_idx, void *data, size_t data_sz)
>
> the previous patch set did:
>   bpf_object__init_internal_map(struct bpf_object *obj, enum
> libbpf_map_type type,
> -                             int sec_idx, Elf_Data *data, void **data_buff)
> +                             int sec_idx, Elf_Data *data)
>
> and now this patch set refactors it again from Elf_Data into
> two individual arguments.
> Could you do this right away in the previous set and avoid this churn?

no problem, will do

> Not a strong opinion though.
> Just odd to see the function being changed back to back.
> Thankfully that's internal in .c file.