netdev - Re: [PATCH v2 1/3] net: macb: fix for fixed-link mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191214203337.687ebd6b@cakuba.netronome.com>
Date:   Sat, 14 Dec 2019 20:33:37 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Milind Parab <mparab@...ence.com>
Cc:     <nicolas.nerre@...rochip.com>, <andrew@...n.ch>,
        <antoine.tenart@...tlin.com>, <f.fainelli@...il.com>,
        <rmk+kernel@...linux.org.uk>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <hkallweit1@...il.com>,
        <linux-kernel@...r.kernel.org>, <dkangude@...ence.com>,
        <a.fatoum@...gutronix.de>, <brad.mouring@...com>,
        <pthombar@...ence.com>
Subject: Re: [PATCH v2 1/3] net: macb: fix for fixed-link mode

On Fri, 13 Dec 2019 09:41:01 +0000, Milind Parab wrote:
> This patch fix the issue with fixed link. With fixed-link
> device opening fails due to macb_phylink_connect not
> handling fixed-link mode, in which case no MAC-PHY connection
> is needed and phylink_connect return success (0), however
> in current driver attempt is made to search and connect to
> PHY even for fixed-link.
> 
> Signed-off-by: Milind Parab <mparab@...ence.com>

We'll wait to give a chance for Russell, Andrew and others to review,
but this patch looks like a fix and the other ones look like features.
You should post the fix separately so it's included in Linus'es tree
ASAP (mark the patch with [PATCH net]), and the rest of the patches can
wait for the next merge window (mark [PATCH net-next]). Fixes should
also have an appropriate Fixes tag pointing at the first commit where
the bug was present.