netdev - Re: [PATCH] hdlcdrv: replace assertion with recovery code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e43a4b92-c236-8f79-ffbb-60bd4bbcb065@web.de>
Date:   Sun, 15 Dec 2019 19:50:03 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Aditya Pakki <pakki001@....edu>, netdev@...r.kernel.org
Cc:     Kangjie Lu <kjlu@....edu>, "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Richard Fontana <rfontana@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hdlcdrv: replace assertion with recovery code

> However, by returning the error to the caller in case ops is NULL
> can avoid the crash.

I suggest to improve this change description by choosing also
a more imperative wording.


> The patch fixes this issue.
Please replace this sentence by the tag “Fixes”.

Regards,
Markus